Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include mypy types #231

Open
devnev opened this issue Nov 29, 2022 · 0 comments
Open

Include mypy types #231

devnev opened this issue Nov 29, 2022 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@devnev
Copy link

devnev commented Nov 29, 2022

Is your feature request related to a problem? Please describe.

Modern python can be type-checked using mypy, but the python distribution of this package does not include the type specs, nor is there a companion type package.

Describe the solution you'd like

Types generated using e.g. https://pypi.org/project/mypy-protobuf/ included either directly in the python googleapis-common-protos package or a separate googleapis-common-protos-stubs package. A separate stubs package might help with avoiding accidental breakage.

Describe alternatives you've considered

I could check in the googleapi protos into the repository where I'm using them and add codegen from that.

Additional context
For the grpcio packages, there's stubs maintained by a third-party, https://pypi.org/project/grpc-stubs/. The protoc plugin https://pypi.org/project/mypy-protobuf/ codegens stubs for proto files (messages and grpc clients/handlers).

@devnev devnev added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 29, 2022
@parthea parthea transferred this issue from googleapis/api-common-protos Jun 4, 2024
@parthea parthea assigned parthea and unassigned vchudnov-g Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants