Skip to content

Conversation

@baeminbo
Copy link

@baeminbo baeminbo commented Nov 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #312

@baeminbo baeminbo requested a review from a team as a code owner November 24, 2021 15:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2021
@tseaver
Copy link
Contributor

tseaver commented Nov 24, 2021

It still feels weird that we are retrying auth-generated errors here -- ISTM that retrying them should be the responsibility of the auth library.

@parthea
Copy link
Collaborator

parthea commented Sep 1, 2023

I'm going to close this PR as retry logic was added in googleapis/google-auth-library-python#1113

@parthea parthea closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RefreshError to retryable errors

3 participants