Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): add packaging requirement #33

Merged
merged 7 commits into from Jun 1, 2021
Merged

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented May 22, 2021

No description provided.

@parthea parthea dismissed their stale review May 22, 2021

Build is failing

@parthea parthea self-assigned this May 22, 2021
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 22, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

Loading

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 25, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

Loading

1 similar comment
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 25, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

Loading

@parthea parthea assigned busunkim96 and unassigned parthea May 28, 2021
@busunkim96 busunkim96 requested a review from parthea Jun 1, 2021
@busunkim96
Copy link
Contributor Author

@busunkim96 busunkim96 commented Jun 1, 2021

Fixed incorrect formatting, please review @parthea

Loading

@busunkim96 busunkim96 assigned parthea and unassigned busunkim96 Jun 1, 2021
parthea
parthea approved these changes Jun 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ca2907e into master Jun 1, 2021
4 checks passed
Loading
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-packaging-dep branch Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants