Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pass the 'params' parameter to the underlying 'BatchPredictReque… #110

Merged
merged 1 commit into from Dec 16, 2020
Merged

fix: Pass the 'params' parameter to the underlying 'BatchPredictReque… #110

merged 1 commit into from Dec 16, 2020

Conversation

elbernante
Copy link
Contributor

fix: Pass the 'params' parameter to the underlying 'BatchPredictRequest' object in 'batch_predict()' method

Fixes issues were the params parameter is ignored in batch_predict() method.

Fixes #109 🦕

@elbernante elbernante requested a review from a team as a code owner December 16, 2020 00:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2020
@product-auto-label product-auto-label bot added the api: automl Issues related to the googleapis/python-automl API. label Dec 16, 2020
busunkim96
busunkim96 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @elbernante!

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2020
@munkhuushmgl
Copy link
Contributor

I will address the issue via #111

https://source.cloud.google.com/results/invocations/8142cdb2-680b-4d32-b327-f3fffda9ed2c/targets/github%2Fpython-automl%2Fsamples%2Fsnippets/tests

@munkhuushmgl munkhuushmgl merged commit b89fb00 into googleapis:master Dec 16, 2020
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
api: automl Issues related to the googleapis/python-automl API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The params parameter is ignored in batch_predict() method
4 participants
@elbernante @munkhuushmgl @busunkim96 @yoshi-kokoro