Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: re-publish tables client documentation #146

Merged
merged 1 commit into from Apr 14, 2021

Conversation

busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Apr 14, 2021

The tables client documentation got deleted on accident - this re-adds the TablesClient and GcsClient under automl_v1beta1. Verify locally by running nox -s docs and looking at the output in docs/_build/html.

Fixes b/184554120

@busunkim96 busunkim96 requested a review from a team as a code owner April 14, 2021 22:08
@product-auto-label product-auto-label bot added the api: automl Issues related to the googleapis/python-automl API. label Apr 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@@ -58,12 +58,11 @@

s.replace(
"docs/automl_v1beta1/services.rst",
"""(google\.cloud\.automl_v1beta1\.services\.prediction_service
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted to match the new format of services.rst.

@@ -79,9 +78,6 @@

s.move(templated_files)

# TODO(busunkim): Use latest sphinx after microgenerator transition
s.replace("noxfile.py", """['"]sphinx['"]""", '"sphinx<3.0.0"')
# TODO(busunkim): Remove after microgenerator transition.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup

@@ -90,12 +86,4 @@
\s+'-T', \# show full traceback on exception""",
""""-T", # show full traceback on exception""")


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like above, cleanup of replacement that is no longer needed

@busunkim96 busunkim96 requested a review from parthea April 14, 2021 22:12
Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9f3e73a into master Apr 14, 2021
7 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the readd-tables-docs branch April 14, 2021 22:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: automl Issues related to the googleapis/python-automl API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants