fix: remove unnecessary double quotes in strings #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I79373e42991c2872ff0f8be215bbfa5b4b460f0c
product-auto-label
bot
added
the
api: automl
google-cla
bot
added
the
cla: yes
aribray
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:run
aribray
added
kokoro:run
yoshi-kokoro
removed
kokoro:run
|
@aribray Even though Removing the ones in the examples linked from #230 should be fine, as that actually shortens those lines. However, the files where those examples occur are in generated code, which means that you need either to apply your changes as replacements in |
|
@tseaver Thanks! I did run |
busunkim96
approved these changes
Oct 7, 2021
|
The 3.7 failure looks like a flake, please try re-running it. |
aribray
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
aribray
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.1](https://www.github.com/googleapis/python-automl/compare/v2.5.0...v2.5.1) (2021-10-20) ### Bug Fixes * remove unnecessary double quotes in strings ([#262](https://www.github.com/googleapis/python-automl/issues/262)) ([fb73bd7](https://www.github.com/googleapis/python-automl/commit/fb73bd7d5ab024aaec3bb0d892c587082911970b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change-Id: I79373e42991c2872ff0f8be215bbfa5b4b460f0c
tables_client.pyuses double quotes for string wrapping. Thepython-automllinter configuration is set to ignore PEP8 E501 errors ("Line too long"), so the string wrapping is unnecessary.Fixes #230🦕
Closes #229