Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary double quotes in strings #262

Merged
merged 3 commits into from Oct 14, 2021

Conversation

aribray
Copy link
Contributor

@aribray aribray commented Oct 5, 2021

Change-Id: I79373e42991c2872ff0f8be215bbfa5b4b460f0c

tables_client.py uses double quotes for string wrapping. The python-automl linter configuration is set to ignore PEP8 E501 errors ("Line too long"), so the string wrapping is unnecessary.

Fixes #230 馃
Closes #229

Change-Id: I79373e42991c2872ff0f8be215bbfa5b4b460f0c
@aribray aribray requested a review from a team as a code owner October 5, 2021 18:37
@product-auto-label product-auto-label bot added the api: automl Issues related to the googleapis/python-automl API. label Oct 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2021
@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@aribray aribray added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@aribray aribray added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 5, 2021
@tseaver
Copy link
Contributor

tseaver commented Oct 5, 2021

@aribray Even though flake8 won't complain about the long lines, we use blacken to keep our code formatted uniformly, and it sets a maximum line length of 88 characters -- some of your changes will cause CI to fail. Try running nox -s lint locally: it runs black in "check" mode, and will fail.

Removing the ones in the examples linked from #230 should be fine, as that actually shortens those lines. However, the files where those examples occur are in generated code, which means that you need either to apply your changes as replacements in owlbot.py, or else work to get the upstream generator to do it for us.

@aribray
Copy link
Contributor Author

aribray commented Oct 5, 2021

@tseaver Thanks! I did run nox -s lint, and it succeeded. But everything you mentioned does make sense. I'll refresh my memory on owlbot.py

@busunkim96
Copy link
Collaborator

The 3.7 failure looks like a flake, please try re-running it.

@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@parthea parthea merged commit fb73bd7 into googleapis:main Oct 14, 2021
10 of 11 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: automl Issues related to the googleapis/python-automl API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoML: docstring typo in TablesClient
5 participants