From 4d6593aec1150ad4c45dae6eb812727aa76f94f1 Mon Sep 17 00:00:00 2001 From: Trevor Bergeron Date: Mon, 6 Oct 2025 20:19:35 +0000 Subject: [PATCH] fix: join on, how args are now positional --- bigframes/dataframe.py | 1 - third_party/bigframes_vendored/pandas/core/frame.py | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/bigframes/dataframe.py b/bigframes/dataframe.py index de153fca48..1bde29506d 100644 --- a/bigframes/dataframe.py +++ b/bigframes/dataframe.py @@ -3721,7 +3721,6 @@ def _validate_left_right_on( def join( self, other: Union[DataFrame, bigframes.series.Series], - *, on: Optional[str] = None, how: str = "left", lsuffix: str = "", diff --git a/third_party/bigframes_vendored/pandas/core/frame.py b/third_party/bigframes_vendored/pandas/core/frame.py index 1d8f5cbace..557c332797 100644 --- a/third_party/bigframes_vendored/pandas/core/frame.py +++ b/third_party/bigframes_vendored/pandas/core/frame.py @@ -4601,9 +4601,8 @@ def map(self, func, na_action: Optional[str] = None) -> DataFrame: def join( self, other, - *, on: Optional[str] = None, - how: str, + how: str = "left", lsuffix: str = "", rsuffix: str = "", ) -> DataFrame: