Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: avoid collision with built-in functions by renaming type property to type_ #53

Merged
merged 3 commits into from Oct 13, 2020

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Sep 16, 2020

BREAKING CHANGE: type is renamed to type_ to avoid conflict with built-in functions (introduced in googleapis/gapic-generator-python#595)

  • testing: use BUILD_SPECIFIC_GCLOUD_PROJECT envvar

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/ee4b6a36-4a41-4223-b32a-41efe623cae3/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@9b0da52

@yoshi-automation yoshi-automation requested review from tmatsuo and removed request for Sep 16, 2020
@google-cla google-cla bot added the cla: yes label Sep 16, 2020
@tmatsuo tmatsuo requested review from tmatsuo and removed request for tmatsuo Oct 2, 2020
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32

`BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Sep 30 13:06:03 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4
Source-Link: googleapis/synthtool@9b0da52
@tmatsuo tmatsuo changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. testing: use BUILD_SPECIFIC_GCLOUD_PROJECT envvar Oct 8, 2020
tmatsuo
tmatsuo approved these changes Oct 8, 2020
@tmatsuo tmatsuo requested a review from tswast Oct 8, 2020
@@ -70,7 +70,7 @@ class DataSourceParameter(proto.Message):
Parameter display name in the user interface.
description (str):
Parameter description.
type (~.datatransfer.DataSourceParameter.Type):
type_ (~.datatransfer.DataSourceParameter.Type):
Copy link
Contributor

@tswast tswast Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. Can we merge separately?

Loading

@tswast tswast changed the title testing: use BUILD_SPECIFIC_GCLOUD_PROJECT envvar fix!: avoid collision with built-in functions by renaming type property to type_ Oct 13, 2020
tswast
tswast approved these changes Oct 13, 2020
@tswast tswast merged commit b954411 into master Oct 13, 2020
8 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants