Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove redundant samples #86

Merged
merged 1 commit into from Dec 21, 2020

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Dec 15, 2020

Snippets updated in internal CL 347667754

Removes redundant samples now that there are copies in the snippets directory from #83

@tswast tswast requested a review from as a code owner Dec 15, 2020
@tswast tswast requested review from tmatsuo and removed request for Dec 15, 2020
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Dec 15, 2020

Here is the summary of changes.

You deleted 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Loading

@tmatsuo
Copy link
Member

@tmatsuo tmatsuo commented Dec 15, 2020

@tswast

The bot currently warns when you delete a region tag which is used by Sample Browser. You can safely ignore the warning because Sample Browser should be able to self heal with the new region tag location.

FYI, we're planning to distinguish the sample browser pages in the future.

Loading

Copy link
Member

@tmatsuo tmatsuo left a comment

Once the internal CL landed (it may take a while for propagating), please use the "Refresh this comment" checkbox in the snippet-bot's comment.

Loading

@tswast tswast merged commit 093e407 into googleapis:master Dec 21, 2020
9 checks passed
Loading
@tswast tswast deleted the b143380740-cleanup-samples branch Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants