Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid 404 if dataset is deleted while listing tables or views #106

Merged

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Mar 31, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #105 馃

@tswast tswast marked this pull request as ready for review Mar 31, 2021
@tswast tswast requested a review from shollyman Apr 1, 2021
@tswast tswast merged commit db379d8 into googleapis:master Apr 1, 2021
3 checks passed
@tswast tswast deleted the issue105-list-tables-view-test-failure branch Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants