Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use project_id property from service account credentials #120

Merged
merged 3 commits into from Apr 12, 2021

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Apr 12, 2021

Adds system tests for greater assurance that these code paths function as expected.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #118 馃

@tswast tswast merged commit ab2051d into googleapis:master Apr 12, 2021
3 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 12, 2021
Copy link
Contributor

@jimfulton jimfulton left a comment

Why a system rather than a unit test?

@pytest.fixture(scope="session")
def module_under_test():
from pybigquery import _helpers

Copy link
Contributor

@jimfulton jimfulton Apr 13, 2021

What's he purpose of this?

Why not just refer to _helpers? Do we think the name is likely to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants