Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select expressions no-longer force use of labels #129

merged 3 commits into from Apr 20, 2021


Copy link

@jimfulton jimfulton commented Apr 20, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #78 馃

jimfulton added 3 commits Apr 20, 2021
The source of the dependency bug is in old versions of google-cloud-core that
depend on too-old versions of google-api-core.
So we don't have t mock at the api level.
@google-cla google-cla bot added the cla: yes label Apr 20, 2021
@jimfulton jimfulton changed the title fix: Select expressions no-longer force use of labels. fix: Select expressions no-longer force use of labels Apr 20, 2021
@jimfulton jimfulton requested a review from tswast Apr 20, 2021
tswast approved these changes Apr 20, 2021
Copy link

@tswast tswast left a comment

Thanks for adding unit tests!

Interesting to use SQLite for unit testing, but I can roll with that.

Long-term we might want to do something with Zeta SQL (name of the BigQuery/Spanner open source implementation), but I think it's a long ways away before we get something usable like a local emulator out of that project.

@tswast tswast merged commit 669b301 into master Apr 20, 2021
3 checks passed
@tswast tswast deleted the riversnake-fix-78 branch Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants