Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support parameterized NUMERIC, BIGNUMERIC, STRING, and BYTES types #180

Merged
merged 8 commits into from May 24, 2021

Conversation

@jimfulton
Copy link
Contributor

@jimfulton jimfulton commented May 21, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #178 馃

@jimfulton jimfulton marked this pull request as ready for review May 22, 2021
@jimfulton jimfulton requested a review from as a code owner May 22, 2021
pybigquery/_helpers.py Outdated Show resolved Hide resolved
pybigquery/sqlalchemy_bigquery.py Show resolved Hide resolved
@jimfulton
Copy link
Contributor Author

@jimfulton jimfulton commented May 24, 2021

@tseaver Thanks for looking at this!

jimfulton added 2 commits May 24, 2021
By splitting string replacement into separate function, substitute_string_re_method.
@jimfulton jimfulton merged commit d118238 into master May 24, 2021
4 checks passed
@jimfulton jimfulton deleted the riversnake-parameterized-types branch May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants