Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Python 3.10 #381

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

aucampia
Copy link
Contributor

@aucampia aucampia commented Dec 21, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #374 馃

NOTE: system test fail for alembic, but that is the same as is happening on main branch, see #382 and #373

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Dec 21, 2021
@aucampia aucampia force-pushed the iwana-20211221T1332-py310 branch 2 times, most recently from af1b93b to 38dccfe Compare December 21, 2021 13:57
@aucampia aucampia marked this pull request as ready for review December 21, 2021 13:57
@aucampia aucampia requested review from a team as code owners December 21, 2021 13:57
@aucampia aucampia changed the title Enable support for 3.10 Enable support for 3.10 [DRAFT] Dec 21, 2021
@aucampia aucampia changed the title Enable support for 3.10 [DRAFT] Enable support for 3.10 Dec 21, 2021
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the patch!

docs/conf.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
owlbot.py Outdated Show resolved Hide resolved
owlbot.py Outdated Show resolved Hide resolved
owlbot.py Show resolved Hide resolved
samples/snippets/requirements.in Outdated Show resolved Hide resolved
@tseaver tseaver changed the title Enable support for 3.10 feat: add support for Python 3.10 Dec 29, 2021
requirements{,-test}.txt are clean up to remove things that are not
needed for tests to pass and to include newer versions of dependencies.
@aucampia
Copy link
Contributor Author

Re-checked nox in samples/snippets:

====================================================================== 2 passed, 6 warnings in 30.16s =======================================================================
nox > Session py-3.10 was successful.
nox > Running session readmegen
nox > Session readmegen skipped: This session had no parameters available..
nox > Ran multiple sessions:
nox > * lint: success
nox > * blacken: success
nox > * py-3.6: success
nox > * py-3.7: success
nox > * py-3.8: success
nox > * py-3.9: success
nox > * py-3.10: success
nox > * readmegen: skipped
20211229T193658 iwana@iwana-pc00.coop.no:~/sw/d/github.com/iafork/python-bigquery-sqlalchemy/samples/snippets
$ 

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2021
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I'll work on getting the system tests passing so that we can merge this soon.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2021
@tswast tswast merged commit 4b3505b into googleapis:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.10 support
4 participants