Fetch table and column descriptions #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mxmzdlv - would appreciate if you could take a look at this when you get a chance |
Contributor
Author
|
@tswast - as the last person to merge code into this repo, do you know who's the right person to ask in order to get some feedback/guidance on this? |
Contributor
|
@hsheth2 - it sometimes takes them some time to get to PRs. |
Contributor
Author
|
@tswast thanks for adding the tests and getting this over the finish line :) |
4 tasks
tswast
added a commit
to tswast/python-bigquery-sqlalchemy
that referenced
this pull request
Apr 6, 2021
This empty commit is a follow-up to PR googleapis#82, It should allow release-please to update the changelog.
4 tasks
tswast
added a commit
that referenced
this pull request
Apr 6, 2021
This empty commit is a follow-up to PR #82, It should allow release-please to update the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly simple change to fetch descriptions during reflection. It just follows the directives set up by the docs https://docs.sqlalchemy.org/en/13/core/internals.html#sqlalchemy.engine.default.DefaultDialect.