Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: build documentation with Sphinx #97

Merged
merged 3 commits into from Mar 25, 2021

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Mar 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #90 馃

@google-cla google-cla bot added the cla: yes label Mar 24, 2021
@tswast tswast requested a review from parthea Mar 25, 2021
Copy link
Contributor

@parthea parthea left a comment

LGTM, Only one observation

README.rst Outdated Show resolved Hide resolved
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1707737 into googleapis:master Mar 25, 2021
3 checks passed
@tswast tswast deleted the issue90-docs branch Mar 25, 2021
@tswast tswast restored the issue90-docs branch Mar 25, 2021
@tswast tswast deleted the issue90-docs branch Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants