Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip some system tests for mtls testing #106

Merged
merged 1 commit into from Jan 5, 2021
Merged

fix: skip some system tests for mtls testing #106

merged 1 commit into from Jan 5, 2021

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Dec 17, 2020

This PR skips the system test cases which use python-bigquery client (in mTLS testing environment only), since bigquery client has no mTLS support yet.

mTLS testing runs on a separate internal system, and this PR has no effect to this repo or any existing testing to this repo.

@arithmetic1728 arithmetic1728 requested a review from as a code owner Dec 17, 2020
@arithmetic1728 arithmetic1728 requested review from tswast and removed request for Dec 17, 2020
@google-cla google-cla bot added the cla: yes label Dec 17, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage label Dec 17, 2020
@arithmetic1728 arithmetic1728 requested a review from busunkim96 Dec 17, 2020
tests/system/v1/test_reader_v1.py Outdated Show resolved Hide resolved
tswast
tswast approved these changes Jan 5, 2021
@tswast tswast merged commit 89ba292 into master Jan 5, 2021
8 checks passed
@tswast tswast deleted the mtls branch Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants