Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clients for v1beta2 endpoint #113

Merged
merged 2 commits into from Jan 13, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jan 12, 2021

This is 100% autogenerated code. Subsequent PRs will cover manual classes.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

TODO:

  • docs build successful
  • unit tests pass (need to remove test_append_rows_flattened_* tests, as there are no flattened arguments for append_rows)

@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Jan 12, 2021
@tswast tswast marked this pull request as ready for review Jan 12, 2021
@tswast tswast requested a review from as a code owner Jan 12, 2021
@tswast tswast requested review from shollyman and removed request for Jan 12, 2021
Copy link
Contributor

@shollyman shollyman left a comment

Always challenging filtering the real changes in these CLs vs the autogen stuff. The synth changes seem reasonable.

I don't understand the presence of both scripts/fixup_bigquery_storage_v1beta2_keywords.py and scripts/fixup_storage_v1beta2_keywords.py in this CL; is one of them spurious?

Also, I don't see these scripts referenced elsewhere; are they one off utilities or do they need to be wired into synth/nox somehow?

Copy link
Contributor

@shollyman shollyman left a comment

Approving based on conversation with swast.

@tswast tswast added the automerge label Jan 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e5f6198 into googleapis:master Jan 13, 2021
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Jan 13, 2021
@tswast tswast deleted the v1beta2 branch Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants