Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't fail with 429 when downloading wide tables #79

Merged
merged 5 commits into from Oct 21, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 19, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #78 馃

@tswast tswast requested a review from as a code owner Oct 19, 2020
@google-cla google-cla bot added the cla: yes label Oct 19, 2020
Copy link

@cguardia cguardia left a comment

This looks good to go.

Copy link
Contributor

@shollyman shollyman left a comment

My only worry with something like this is that the synth change looks brittle, but if we've got a good signal for when synth changes aren't matching that's probably okay.

@tswast
Copy link
Contributor Author

@tswast tswast commented Oct 21, 2020

got a good signal for when synth changes aren't matching that's probably okay.

When running manually, we get a nice warning that it didn't match anything. Not sure what autosynth does in that case, though.

@tswast tswast merged commit 45faf97 into googleapis:master Oct 21, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants