Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add intersphinx to proto-plus library #86

Merged
merged 6 commits into from Nov 4, 2020

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Oct 28, 2020

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/56edb2e9-da3a-409f-a2ed-e969b45e2c63/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@ea52b8a
Source-Link: googleapis/synthtool@fd3584b

Perviously, system tests allow users to pass in separate lists for `system_test_external_dependencies` and `unit_test_local_dependencies`, which would install dependencies needed for the test. Unit tests only had a single option called `unit_test_dependencies`, which only supported local packages.

This PR makes unit tests consistent with system tests by handling `unit_test_external_dependencies` and `unit_test_local_dependencies`. I kept  `unit_test_dependencies` around with it's previous behaviour for backwards compatibility, in case any repos are using it as-is.

Source-Author: Daniel Sanche <d.sanche14@gmail.com>
Source-Date: Mon Oct 26 13:46:03 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: fd3584b01cedd6c9f79d08be4e2365085f955aa5
Source-Link: googleapis/synthtool@fd3584b
Source-Author: Tim Swast <swast@google.com>
Source-Date: Tue Oct 27 12:01:14 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: ea52b8a0bd560f72f376efcf45197fb7c8869120
Source-Link: googleapis/synthtool@ea52b8a
@yoshi-automation yoshi-automation requested a review from googleapis/api-bigquery as a code owner Oct 28, 2020
@google-cla google-cla bot added the cla: yes label Oct 28, 2020
tswast added 3 commits Nov 4, 2020
@tswast tswast changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. docs: add intersphinx to proto-plus library Nov 4, 2020
@tswast
tswast approved these changes Nov 4, 2020
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Nov 4, 2020

Your PR has conflicts that you need to resolve before merge-on-green can automerge

@gcf-merge-on-green gcf-merge-on-green bot merged commit 4cd35d2 into master Nov 4, 2020
8 checks passed
8 checks passed
Kokoro Build successful
Details
Kokoro docs-presubmit Build successful
Details
Samples - Lint Build successful
Details
Samples - Python 3.6 Build successful
Details
Samples - Python 3.7 Build successful
Details
Samples - Python 3.8 Build successful
Details
cla/google All necessary CLAs are signed
conventionalcommits.org
Details
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 10, 2020
Follow-up to #86 where I manually reverted a change to `noxfile.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants