Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow queryJob.result() to be called on a dryRun #1015

Merged
merged 3 commits into from Oct 13, 2021

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Oct 11, 2021

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1012 馃

@steffnay steffnay requested a review from a team October 11, 2021 21:45
@steffnay steffnay requested a review from a team as a code owner October 11, 2021 21:45
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 11, 2021
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify the tests a bit.

tests/unit/job/test_query.py Outdated Show resolved Hide resolved
tests/unit/job/test_query.py Outdated Show resolved Hide resolved

calls = conn.api_request.mock_calls
self.assertEqual(result, None)
self.assertEqual(calls, [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for checking that there were no API requests.

google/cloud/bigquery/job/query.py Outdated Show resolved Hide resolved
@steffnay steffnay requested a review from tswast October 12, 2021 21:38
tswast
tswast approved these changes Oct 13, 2021
@tswast tswast merged commit 685f06a into googleapis:main Oct 13, 2021
13 checks passed
@tswast
Copy link
Contributor

tswast commented Oct 13, 2021

Thanks @steffnay !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow QueryJob.result() to be called on a dryRun query
2 participants