Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Python 3.10 #1043

Merged
merged 7 commits into from Nov 3, 2021
Merged

feat: support Python 3.10 #1043

merged 7 commits into from Nov 3, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 3, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1006 馃
Towards googleapis/python-bigquery-datatransfer#244

@tswast tswast requested a review from a team November 3, 2021 14:42
@tswast tswast requested review from a team as code owners November 3, 2021 14:42
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 3, 2021
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the Samples check with Python 3.10? And shouldn't we also run the system tests with the latest supported Python version?

Currently we only run them with Python 3.8.

samples/geography/requirements.txt Show resolved Hide resolved
samples/snippets/requirements.txt Show resolved Hide resolved
@tswast tswast requested a review from plamut November 3, 2021 16:28
tseaver
tseaver approved these changes Nov 3, 2021
@tswast
Copy link
Contributor Author

tswast commented Nov 3, 2021

Need to skip installing geopandas on 3.10

@tswast
Copy link
Contributor Author

tswast commented Nov 3, 2021

I didn't see an open issue for geopandas Python 3.10 support, so I filed geopandas/geopandas#2212

@tswast tswast added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Nov 3, 2021
@tswast
Copy link
Contributor Author

tswast commented Nov 3, 2021

Mailed internal change 407388245 to enable system tests on Python 3.10

@tswast tswast merged commit 5bbb832 into main Nov 3, 2021
15 checks passed
@tswast tswast deleted the issue1006-python310 branch November 3, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.10 support
3 participants