Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error if eval()-ing repr(SchemaField) #1046

Merged
merged 5 commits into from Nov 4, 2021
Merged

fix: error if eval()-ing repr(SchemaField) #1046

merged 5 commits into from Nov 4, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Nov 4, 2021

Fixes #1041.

If policy tags are not set, the corresponding key should be None to denote a missing value. An empty tuple should only be used when the schema has explicitly empty PolicyTagList assigned.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from tswast and a team November 4, 2021 10:15
@plamut plamut requested a review from a team as a code owner November 4, 2021 10:15
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 4, 2021
tseaver
tseaver reviewed Nov 4, 2021
View reviewed changes
tests/unit/test_schema.py
evaled_field = eval(field_repr)

assert field == evaled_field

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, do we need a round-trip test for the case where there is a policy tuple?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not hurt, I'll add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess what, that extra test actually revealed deeper issues in the repr() of SchemaField and PolicyTagList.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W00t!

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2021
@plamut plamut requested a review from tseaver November 4, 2021 15:14
@plamut plamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2021
tswast
tswast approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit 13ac860 into googleapis:main Nov 4, 2021
15 checks passed
@plamut plamut deleted the iss-1041 branch November 4, 2021 21:10
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@tseaver tseaver

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SchemaField cannot initialize from __repr__
3 participants
@plamut @tseaver @tswast