Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promote RowIterator.to_arrow_iterable to public method #1073

Merged
merged 3 commits into from Nov 19, 2021

Conversation

@judahrand
Copy link
Contributor

@judahrand judahrand commented Nov 19, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1072 馃

@judahrand judahrand requested review from as code owners Nov 19, 2021
@judahrand judahrand requested a review from tswast (assigned from googleapis/api-bigquery) Nov 19, 2021
@google-cla google-cla bot added the cla: yes label Nov 19, 2021
@judahrand judahrand force-pushed the to_arrow_iterable branch 2 times, most recently from 9c42717 to dd57bb1 Nov 19, 2021
@judahrand judahrand force-pushed the to_arrow_iterable branch from dd57bb1 to 98d157c Nov 19, 2021
@tswast tswast changed the title Promote to_arrow_iterable to public method feat: promote RowIterator.to_arrow_iterable to public method Nov 19, 2021
tswast
tswast approved these changes Nov 19, 2021
Copy link
Contributor

@tswast tswast left a comment

Thanks for the contribution!

google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
@tswast tswast merged commit 21cd710 into googleapis:main Nov 19, 2021
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants