Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigquery): add client thread-safety documentation #132

Merged
merged 3 commits into from Jun 15, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Jun 11, 2020

Fixes #129

Copy link
Contributor

@plamut plamut left a comment

Just two nits (disclaimer: I'm not a native speaker).

As for the thread safety, I scanned the Client code and it does not really have much state, except for a few internal properties and the project attribute. There is also the close() method, but that just operates on requests objects or their subclasses, e.g. google.auth.transport.AuthorizedSession.

Using a shared client is thus (probably) fine.

Loading

docs/index.rst Outdated Show resolved Hide resolved
Loading
docs/index.rst Outdated Show resolved Hide resolved
Loading
plamut
plamut approved these changes Jun 12, 2020
Copy link
Contributor

@plamut plamut left a comment

LGTM. Decide on your own if we need to change the spelling, since I'm not sure if my remark is indeed valid.

Loading

docs/index.rst Outdated Show resolved Hide resolved
Loading
@HemangChothani HemangChothani merged commit fce76b3 into googleapis:master Jun 15, 2020
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants