Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for getting and setting table IAM policy #144

Merged
merged 16 commits into from Jul 30, 2020

Conversation

@steffnay
Copy link
Contributor

@steffnay steffnay commented Jun 23, 2020

Adds support for interacting with IAM policies for BigQuery table resources.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

馃

@steffnay steffnay requested a review from shollyman Jun 23, 2020
@steffnay steffnay changed the title Table acl feat: adds support for getting and setting table IAM policy Jul 13, 2020
@steffnay steffnay marked this pull request as ready for review Jul 14, 2020
Copy link
Contributor

@shollyman shollyman left a comment

One thing that's missing here is the testIamPermissions implementation and accompanying. Is that going to be in a followup PR?

Loading

google/cloud/bigquery/iam.py Outdated Show resolved Hide resolved
Loading
@shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 24, 2020

Testing is picking up unit test problems with pyarrow tests. Looks like they just jumped from 0.17.1 to 1.0, so possibly some more shenanigans afoot with changes there.

Loading

@shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 24, 2020

Given it's friday afternoon now, punting a release window on this until next week.

Loading

@shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 24, 2020

And ignore the previous two comments, I've been typing in the wrong PR

Loading

@steffnay steffnay requested a review from shollyman Jul 28, 2020
@tseaver tseaver changed the title feat: adds support for getting and setting table IAM policy feat: add support for getting and setting table IAM policy Jul 29, 2020
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
tests/system.py Outdated Show resolved Hide resolved
Loading
tests/unit/test_client.py Show resolved Hide resolved
Loading
tests/unit/test_client.py Outdated Show resolved Hide resolved
Loading
@tseaver tseaver merged commit f59fc9a into googleapis:master Jul 30, 2020
7 of 8 checks passed
Loading
@brandonjchoi
Copy link

@brandonjchoi brandonjchoi commented Aug 17, 2020

When will this be released @tseaver @shollyman ?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants