Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): expose date_as_object parameter to users #150

Merged
merged 6 commits into from Jun 29, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Jun 26, 2020

Fixes #11

Copy link
Contributor

@plamut plamut left a comment

Two doc nits, but more importantly we need an additional test for this new feature when pyarrow is not installed.

Loading

google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
Loading
tests/unit/test_job.py Show resolved Hide resolved
Loading
google/cloud/bigquery/table.py Show resolved Hide resolved
Loading
@plamut plamut changed the title feat(bigquery): expose date_as_object parameter for users feat(bigquery): expose date_as_object parameter to users Jun 26, 2020
Copy link
Contributor

@plamut plamut left a comment

Looks good, please just fix the missing parentheses in docstrings.

Loading

google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
Loading
plamut
plamut approved these changes Jun 29, 2020
Copy link
Contributor

@plamut plamut left a comment

LGTM.

Loading

google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
Loading
@plamut plamut merged commit a2d5ce9 into googleapis:master Jun 29, 2020
3 checks passed
Loading
q-logic pushed a commit to q-logic/python-bigquery that referenced this issue Jun 30, 2020
)

* feat(bigquery): expose date_as_object parameter for users

* feat(bigquery): nit

* feat(bigquery): add unit test for date as object without pyarrow

* feat(bigquery): docs fixed

* feat(bigquery): nit

* feat(bigquery): nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants