Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigquery): consistent use of optional keyword #153

Merged
merged 2 commits into from Jun 30, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Jun 30, 2020

Fixes #152

Copy link
Contributor

@plamut plamut left a comment

Looks really good, thanks for addressing this!

Found just a few things (capitalization, usages of Optional), and once fixed we can merge this IMO.

Loading

google/cloud/bigquery/_pandas_helpers.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/model.py Outdated Show resolved Hide resolved
Loading
plamut
plamut approved these changes Jun 30, 2020
@HemangChothani HemangChothani merged commit 79d8c61 into googleapis:master Jun 30, 2020
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants