Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add __eq__ method for class PartitionRange and RangePartitioning #162

Merged
merged 4 commits into from Jul 13, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Jul 10, 2020

Fixes #159

Copy link
Contributor

@plamut plamut left a comment

Mutable objects should not advertise themselves as hashable, otherwise looks good.

Loading

google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
Loading
Copy link
Contributor

@plamut plamut left a comment

Looks good, I would just change the hashability assertions to a more explicit form rather than testing the "implementation detail".

Loading

tests/unit/test_table.py Outdated Show resolved Hide resolved
Loading
plamut
plamut approved these changes Jul 13, 2020
Copy link
Contributor

@plamut plamut left a comment

LGTM

Loading

@plamut plamut merged commit 0d2a88d into googleapis:master Jul 13, 2020
3 of 7 checks passed
Loading
@francois-baptiste
Copy link
Contributor

@francois-baptiste francois-baptiste commented Jul 13, 2020

Great! Thank you @HemangChothani

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants