Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add __eq__ method for class PartitionRange and RangePartitioning #162

Merged
merged 4 commits into from Jul 13, 2020
Merged

feat(bigquery): add __eq__ method for class PartitionRange and RangePartitioning #162

merged 4 commits into from Jul 13, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #159

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
plamut
plamut suggested changes Jul 10, 2020
View changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutable objects should not advertise themselves as hashable, otherwise looks good.

google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
plamut
plamut reviewed Jul 13, 2020
View changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just change the hashability assertions to a more explicit form rather than testing the "implementation detail".

tests/unit/test_table.py Outdated Show resolved Hide resolved
plamut
plamut approved these changes Jul 13, 2020
View changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut plamut merged commit 0d2a88d into googleapis:master Jul 13, 2020
2 of 6 checks passed
@francois-baptiste
Copy link
Contributor

Great! Thank you @HemangChothani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparaison between RangePartitioning objects seems to be incorrect.
4 participants
@HemangChothani @francois-baptiste @plamut @googlebot