Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigquery): add docstring for conflict exception #171

Merged
merged 3 commits into from Jul 20, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Jul 16, 2020

Fixes #123

@HemangChothani HemangChothani requested a review from plamut Jul 16, 2020
@google-cla google-cla bot added the cla: yes label Jul 16, 2020
Copy link
Contributor

@plamut plamut left a comment

Apart from the missing colons the changes look good. Samples test failures are irrelevant, as the samples have not been migrated yet.

Loading

@@ -441,6 +441,10 @@ def create_dataset(
google.cloud.bigquery.dataset.Dataset:
A new ``Dataset`` returned from the API.
Raises:
google.cloud.exceptions.Conflict
Copy link
Contributor

@plamut plamut Jul 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colons are missing at the end of exception types.

Loading

plamut
plamut approved these changes Jul 17, 2020
@plamut plamut merged commit 9c3409b into googleapis:master Jul 20, 2020
3 of 7 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants