Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RowIterator.to_arrow() error when BQ Storage client cannot be created #181

Merged
merged 2 commits into from Jul 23, 2020

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jul 23, 2020

Fixes #177. 馃

This PR fixes the error in RowIterator.to_arrow() when the method should create and use a BQ Storage client, but the optional google-cloud-bigquery-storage dependency is not installed and thus the client cannot be created.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@google-cla google-cla bot added the cla: yes label Jul 23, 2020
@plamut plamut changed the title Fixes Iss 177 fix: RowIterator.to_arrow() error when BQ Storage client cannot be created Jul 23, 2020
Copy link
Contributor

@shollyman shollyman left a comment

Thanks for getting this together.

Independent of this change, should we consider something like a nox session that's parameterized to run a subset of the system or snippet tests with different combinations of optional deps?

Loading

@plamut
Copy link
Contributor Author

@plamut plamut commented Jul 23, 2020

Depending on the number of dependency combinations that we want to test and the slowness of the target tests, it might be an overkill to run them for every PR, but how about setting up regular nightly runs? And possibly also run such an extensive suite before every release?

Loading

@plamut plamut merged commit 7afa3d7 into googleapis:master Jul 23, 2020
7 checks passed
Loading
@plamut plamut deleted the iss-177 branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants