Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add client_options to base class #216

Merged
merged 3 commits into from Aug 14, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Aug 10, 2020

Fixes #178 馃

@HemangChothani HemangChothani requested a review from plamut Aug 10, 2020
@google-cla google-cla bot added the cla: yes label Aug 10, 2020
@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 10, 2020

Docs build broke due to Sphinx 3.2.0 release. See #217 / PR #218.

Loading

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 10, 2020

@HemangChothani PR #218 has landed, fixing the docs session (#217). You'll need to merge master yourself (the PR branch is blocked for maintainer edits / merges).

Loading

setup.py Outdated
@@ -31,7 +31,7 @@
dependencies = [
'enum34; python_version < "3.4"',
"google-api-core >= 1.21.0, < 2.0dev",
"google-cloud-core >= 1.1.0, < 2.0dev",
"google-cloud-core >= 1.4.0, < 2.0dev",
Copy link
Contributor

@busunkim96 busunkim96 Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"google-cloud-core >= 1.4.0, < 2.0dev",
"google-cloud-core >= 1.4.1, < 2.0dev",

Loading

@HemangChothani HemangChothani merged commit 478597a into googleapis:master Aug 14, 2020
10 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants