Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instrumentation to list methods #239

Merged
merged 54 commits into from Aug 24, 2020

Conversation

aravinsiva
Copy link
Contributor

@aravinsiva aravinsiva commented Aug 22, 2020

PR adds opentelemetry instrumentation to all methods that don't directly make api calls and instead use an HTTPIterator.,

Fixes ##221 馃

aravinsiva and others added 30 commits August 1, 2020 17:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 22, 2020
page = six.next(iterator.pages)

with mock.patch(
"google.cloud.bigquery.opentelemetry_tracing._get_final_span_attributes"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional comment: this is a really long string that is repeated many times in this file. It's probably a good idea to put it in a const string in your test client.

Since that would affect a bunch of other tests in this file, it would be best to do in a separate PR.

@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 24, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 24, 2020
@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 24, 2020
tswast
tswast approved these changes Aug 24, 2020
@tswast tswast changed the title feat: adding instrumentation to methods that don't directly call API feat: add instrumentation to list methods Aug 24, 2020
@tswast tswast merged commit fa9f9ca into googleapis:master Aug 24, 2020
9 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 22, 2020
馃 I have created a release \*beep\* \*boop\* 
---
## [1.28.0](https://www.github.com/googleapis/python-bigquery/compare/v1.27.2...v1.28.0) (2020-09-22)


### Features

* add custom cell magic parser to handle complex `--params` values ([#213](https://www.github.com/googleapis/python-bigquery/issues/213)) ([dcfbac2](https://www.github.com/googleapis/python-bigquery/commit/dcfbac267fbf66d189b0cc7e76f4712122a74b7b))
* add instrumentation to list methods ([#239](https://www.github.com/googleapis/python-bigquery/issues/239)) ([fa9f9ca](https://www.github.com/googleapis/python-bigquery/commit/fa9f9ca491c3f9954287102c567ec483aa6151d4))
* add opentelemetry tracing ([#215](https://www.github.com/googleapis/python-bigquery/issues/215)) ([a04996c](https://www.github.com/googleapis/python-bigquery/commit/a04996c537e9d8847411fcbb1b05da5f175b339e))
* expose require_partition_filter for hive_partition ([#257](https://www.github.com/googleapis/python-bigquery/issues/257)) ([aa1613c](https://www.github.com/googleapis/python-bigquery/commit/aa1613c1bf48c7efb999cb8b8c422c80baf1950b))


### Bug Fixes

* fix dependency issue in fastavro ([#241](https://www.github.com/googleapis/python-bigquery/issues/241)) ([2874abf](https://www.github.com/googleapis/python-bigquery/commit/2874abf4827f1ea529519d4b138511d31f732a50))
* update minimum dependency versions ([#263](https://www.github.com/googleapis/python-bigquery/issues/263)) ([1be66ce](https://www.github.com/googleapis/python-bigquery/commit/1be66ce94a32b1f924bdda05d068c2977631af9e))
* validate job_config.source_format in load_table_from_dataframe ([#262](https://www.github.com/googleapis/python-bigquery/issues/262)) ([6160fee](https://www.github.com/googleapis/python-bigquery/commit/6160fee4b1a79b0ea9031cc18caf6322fe4c4084))


### Documentation

* recommend insert_rows_json to avoid call to tables.get ([#258](https://www.github.com/googleapis/python-bigquery/issues/258)) ([ae647eb](https://www.github.com/googleapis/python-bigquery/commit/ae647ebd68deff6e30ca2cffb5b7422c6de4940b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants