Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove redundant array deepcopy #26

Merged
merged 7 commits into from Oct 7, 2020
Merged

Conversation

@grooveygr
Copy link
Contributor

@grooveygr grooveygr commented Feb 6, 2020

Deepcopy can be a very costly operation when considering large arrays with complex nested objects.
Refactor helpers to allow recursive conversion without copying arrays.

Fixes #6 馃

deepcopy can be a very costly operation when considering large arrays with complex nested objects.
refactor helpers to allow recursive conversion without copying arrays.
@tseaver tseaver changed the title perf(bigquery): remove redundant array deepcopy perf: remove redundant array deepcopy Jul 30, 2020
@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 30, 2020

@plamut I'm less familiar than you with this bit of the code. PTAL.

Loading

@busunkim96 busunkim96 closed this Jul 31, 2020
@busunkim96 busunkim96 reopened this Jul 31, 2020
@tswast tswast requested a review from as a code owner Sep 24, 2020
tests/unit/test__helpers.py Show resolved Hide resolved
Loading
tswast
tswast approved these changes Oct 6, 2020
google/cloud/bigquery/_helpers.py Outdated Show resolved Hide resolved
Loading
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@tswast tswast merged commit b54f867 into googleapis:master Oct 7, 2020
9 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants