Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing spaces in opentelemetry log message #360

Merged
merged 2 commits into from Nov 3, 2020

Conversation

@rickard-von-essen
Copy link
Contributor

@rickard-von-essen rickard-von-essen commented Nov 3, 2020

Currently this log message renders like this:

This service is instrumented using OpenTelemetry.OpenTelemetry could not be imported; pleaseadd opentelemetry-api and opentelemetry-instrumentationpackages in order to get BigQuery Tracing data.

where it should be

This service is instrumented using OpenTelemetry. OpenTelemetry could not be imported; please add opentelemetry-api and opentelemetry-instrumentation packages in order to get BigQuery Tracing data."
@rickard-von-essen rickard-von-essen requested a review from as a code owner Nov 3, 2020
@rickard-von-essen rickard-von-essen requested a review from shollyman Nov 3, 2020
@google-cla google-cla bot added the cla: yes label Nov 3, 2020
@rickard-von-essen rickard-von-essen force-pushed the patch-1 branch 2 times, most recently from 0202861 to c8bd8cf Nov 3, 2020
Currently this log message renders like this:

```
This service is instrumented using OpenTelemetry.OpenTelemetry could not be imported; pleaseadd
opentelemetry-api and opentelemetry-instrumentationpackages in order to get BigQuery Tracing data.
```

where it should be

```
This service is instrumented using OpenTelemetry. OpenTelemetry could not be imported; please add
opentelemetry-api and opentelemetry-instrumentation packages in order to get BigQuery Tracing data."
```
tswast
tswast approved these changes Nov 3, 2020
@tswast tswast changed the title Add missing spaces in log message fix: add missing spaces in opentelemetry log message Nov 3, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4f326b1 into googleapis:master Nov 3, 2020
10 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants