Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use jobs.getQueryResults to download result sets #363



Copy link

@tswast tswast commented Nov 3, 2020

Replaces tabledata.list when RowIterator is used for query results.
This likely also fixes a few edge cases around BigQuery scripting jobs.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Based on #361
Towards #362 馃

tswast added 2 commits Nov 3, 2020
Original paths are retained for backwards compatibility.
Replaces `tabledata.list` when `RowIterator` is used for query results.
This likely also fixes a few edge cases around BigQuery scripting jobs.
Copy link

@shollyman shollyman left a comment

Looks good. If you end up reusing _list_rows_from_query_results for the done polling you may need to consider that explicit project list, but it seems you're being distinct between the job polling and iteration usages here.


google/cloud/bigquery/ Show resolved Hide resolved
@tswast tswast merged commit 0c3476d into googleapis:master Nov 4, 2020
10 checks passed
@tswast tswast deleted the issue362-getQueryResults-RowIterator branch Nov 4, 2020
@tswast tswast mentioned this pull request Nov 5, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants