Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow partial streaming_buffer statistics #37

Merged
merged 6 commits into from Feb 14, 2020

Conversation

@shollyman
Copy link
Contributor

@shollyman shollyman commented Feb 13, 2020

Previously, the BQ backend would supply all fields of the
streamingBuffer statistics or none. This is no longer the
case, so we relax construction to not depend on all values
being present.

Related: internal issue b/148720220

shollyman added 2 commits Feb 13, 2020
Previously, the BQ backend would supply all fields of the
streamingBuffer statistics or none.  This is no longer the
case, so we relax construction to not depend on all values
being present.

Related: internal issue b/148720220
@shollyman shollyman changed the title fix: allow partial streaming_buffer statistics. fix: allow partial streaming_buffer statistics Feb 13, 2020
Copy link
Contributor

@plamut plamut left a comment

LGTM.

The coverage failure seems legitimate, should be fixed.

Loading

@shollyman shollyman merged commit 645f0fd into googleapis:master Feb 14, 2020
3 checks passed
Loading
@shollyman shollyman deleted the fixstreaming branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants