Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow routine references #378

Merged
merged 5 commits into from Nov 10, 2020

Conversation

@cguardia
Copy link
Contributor

@cguardia cguardia commented Nov 10, 2020

The Access property of a dataset now allows references to Routine entities.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #353 馃

@cguardia cguardia requested a review from as a code owner Nov 10, 2020
@cguardia cguardia requested a review from tswast Nov 10, 2020
@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@cguardia cguardia changed the title 353 allow routine references feat: allow routine references Nov 10, 2020
@cguardia cguardia force-pushed the 353-allow-routine-references branch from f645e49 to 76eeb96 Nov 10, 2020
tswast
tswast approved these changes Nov 10, 2020
Copy link
Contributor

@tswast tswast left a comment

Thanks!

Loading

@tswast tswast merged commit f9480dc into googleapis:master Nov 10, 2020
10 checks passed
Loading
@cguardia cguardia deleted the 353-allow-routine-references branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants