Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid extra API calls from to_dataframe if all rows are cached #384

Merged
merged 1 commit into from Nov 11, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 11, 2020

Follow-up to previous PR, which cached the first page of
getQueryResults. If the first page is the only page (no pageToken),
then it is unnecessary to make extra API calls from to_dataframe or
to_arrow to the BigQuery Storage API.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #362 馃

Follow-up to previous PR, which cached the first page of
`getQueryResults`. If the first page is the only page (no `pageToken`),
then it is unnecessary to make extra API calls from `to_dataframe` or
`to_arrow` to the BigQuery Storage API.
@tswast tswast requested review from a team and stephaniewang526 November 11, 2020 18:09
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 11, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2020
@tswast tswast mentioned this pull request Nov 11, 2020
7 tasks
@tswast tswast requested review from shollyman and removed request for stephaniewang526 November 11, 2020 18:10
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rows are coming...from inside the house!

@tswast tswast merged commit c52b317 into googleapis:master Nov 11, 2020
9 checks passed
@tswast tswast deleted the issue362-to_dataframe branch November 11, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants