Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbapi): allow rows to be fetched from scripts #387

Merged

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 12, 2020

The is_dml logic is not needed now that we moved to getQueryResults instead of tabledata.list (#375).

Previously, the destination table of a DML query would return a non-null value that was unreadable or would return nonsense with DML (and some DDL) queries.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #377 馃

@tswast tswast requested review from a team and pmakani November 12, 2020 23:08
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 12, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@tswast tswast requested review from shollyman and removed request for pmakani November 12, 2020 23:09
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit b899ad1 into googleapis:master Nov 12, 2020
8 of 9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2020
@tswast tswast deleted the issue377-dbapi-scripting branch November 12, 2020 23:43
@mistercrunch
Copy link
Contributor

happy

@mistercrunch
Copy link
Contributor

Big thanks for making this happen, this enabled us to ship this: apache/superset#11904

We're planning more work around creating a great experience around BigQuery in Superset, looking forward to more collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants