Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support CSV format in load_table_from_dataframe pandas connector #399

Merged

Conversation

@cguardia
Copy link
Contributor

@cguardia cguardia commented Nov 24, 2020

for load_table_from_dataframe

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #383 馃

for load_table_from_dataframe
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
tests/system.py Outdated Show resolved Hide resolved
Loading
tests/system.py Show resolved Hide resolved
Loading
@cguardia
Copy link
Contributor Author

@cguardia cguardia commented Dec 2, 2020

@tswast sorry for the delay. I think this addresses your comments.

Loading

google/cloud/bigquery/client.py Show resolved Hide resolved
Loading
@tswast tswast changed the title WIP: support alternative serialization formats feat: support CSV format in load_table_from_dataframe pandas connector Dec 7, 2020
tswast
tswast approved these changes Dec 7, 2020
@tswast tswast merged commit 0046742 into googleapis:master Dec 7, 2020
10 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants