Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update intersphinx links #404

Merged
merged 4 commits into from Dec 7, 2020
Merged

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Nov 30, 2020

Also, updates synth.py to avoid manual hacks, such as to work around the breaking change in #316 until we figure out how to use proto-plus classes directly #319.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Closes #336
Closes #325
Closes #316

@tswast
Copy link
Contributor Author

@tswast tswast commented Nov 30, 2020

Generated with python -m synthtool on the latest synthtool commit, checked out locally.

Loading

@tswast tswast requested a review from shollyman Dec 2, 2020
Copy link
Contributor

@shollyman shollyman left a comment

Approving, with the caveat that it's not clear what here is generated vs manual config change.

Loading

@tswast tswast requested review from steffnay and crwilcox Dec 3, 2020
@tswast
Copy link
Contributor Author

@tswast tswast commented Dec 3, 2020

Thanks @shollyman

The only manual changes are to synth.py

Loading

@tswast tswast merged commit a9d8ae8 into googleapis:master Dec 7, 2020
10 checks passed
Loading
@tswast tswast deleted the restore-py_samples branch Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants