Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refresh view samples #420

Merged
merged 1 commit into from Dec 10, 2020
Merged

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Dec 7, 2020

These snippets are copied from snippets.py and refreshed
to include imports and client construction. Will follow up
with a PR to remove the redundant snippets once the docs
on cloud.google.com are updated.

I notice that the tests for these snippets have been skipped.
I believe that was due to a temporary rollout issue with
table update. If that actually is flakier than I thought, we
can more easily add retries or disable just updates in this
new structure.

def test_manage_views(client, to_delete):

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 173133642 馃

@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Dec 7, 2020

Here is the summary of changes.

You added 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Loading

@tmatsuo
Copy link
Member

@tmatsuo tmatsuo commented Dec 8, 2020

Re: snippet-bot's comment

I guess you're moving samples under samples dir. The bot is warning because some region tags are referenced from the devsite doc. This will cause 404 errors on our devsite pages.

I think the correct course of action is to 1) duplicate the sample, 2) update devsite, then 3) remove the old tags.

Loading

@tswast tswast force-pushed the b173133642-view-samples branch from b80cd52 to 58f2d2d Dec 8, 2020
@tswast tswast changed the title docs: move and refresh view samples docs: refresh view samples Dec 8, 2020
@tswast tswast marked this pull request as ready for review Dec 8, 2020
@tswast tswast requested a review from as a code owner Dec 8, 2020
@tswast tswast requested review from crwilcox, shollyman and steffnay and removed request for Dec 8, 2020
@tswast
Copy link
Contributor Author

@tswast tswast commented Dec 8, 2020

Thanks @tmatsuo for looking. Yes, I am trying to move these samples. I'll try your suggested process.

Loading

docs: restore old view snippets

remove relative imports

docs: fix missing space in comment

sort imports
@tswast tswast force-pushed the b173133642-view-samples branch from fa645bf to 8240434 Dec 9, 2020
@tswast tswast merged commit 079b6a1 into googleapis:master Dec 10, 2020
10 of 11 checks passed
Loading
@tswast tswast deleted the b173133642-view-samples branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants