Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add GEOGRAPHY data type code samples #428

Merged
merged 2 commits into from Dec 9, 2020

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Dec 9, 2020

These are added to a separate directory in order to isolate the GeoJSON
and WKT dependencies from the other code samples.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal 171804665

These are added to a separate directory in order to isolate the GeoJSON
and WKT dependencies from the other code samples.
@tswast tswast requested a review from as a code owner Dec 9, 2020
@tswast tswast requested review from tmatsuo and removed request for Dec 9, 2020
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Dec 9, 2020

Here is the summary of changes.

You added 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Loading

@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@tswast tswast requested review from steffnay and shollyman Dec 9, 2020
@tswast tswast requested a review from as a code owner Dec 9, 2020
SELECT name, SUM(number) AS total_people
FROM `bigquery-public-data.usa_names.usa_1910_current`
GROUP BY name
SELECT COUNT(*)
Copy link
Contributor Author

@tswast tswast Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really associated with this sample, but the system test flaked, so I figured I'd swap out this query with one from go/bq-long-queries

Loading

Copy link
Contributor

@shollyman shollyman Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Loading

Copy link
Contributor

@shollyman shollyman left a comment

I was today years old when I found out that streaming inserts will accept either WKT or geojson as the field contents.

Loading

SELECT name, SUM(number) AS total_people
FROM `bigquery-public-data.usa_names.usa_1910_current`
GROUP BY name
SELECT COUNT(*)
Copy link
Contributor

@shollyman shollyman Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Loading

import nox


# WARNING - WARNING - WARNING - WARNING - WARNING
Copy link
Contributor

@shollyman shollyman Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated?

Loading

Copy link
Contributor Author

@tswast tswast Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

@tswast tswast merged commit dbc68b3 into googleapis:master Dec 9, 2020
10 of 11 checks passed
Loading
@tswast tswast deleted the b171804665-geography branch Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants