Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reading the labels attribute on Job instances #471

Merged
merged 1 commit into from Jan 14, 2021

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jan 14, 2021

Fixes #469.

This PR fixes reading the labels on Job instances and adds a system test that would have caught this bug.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from as a code owner Jan 14, 2021
@plamut plamut requested review from steffnay and removed request for Jan 14, 2021
@google-cla google-cla bot added the cla: yes label Jan 14, 2021
tswast
tswast approved these changes Jan 14, 2021
Copy link
Contributor

@tswast tswast left a comment

Thanks!

Can confirm in https://cloud.google.com/bigquery/docs/reference/rest/v2/Job#JobConfiguration that this is how it's supposed to be (labels are a property of configuration)

Loading

@tswast tswast merged commit 80944f0 into googleapis:master Jan 14, 2021
10 of 11 checks passed
Loading
@plamut plamut deleted the iss-469 branch Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants