Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use explicitly given project over the client's default project for load jobs #482

Merged
merged 4 commits into from Jan 22, 2021

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jan 22, 2021

Fixes #473.

This PR fixes the ignored project parameter for load jobs (the client's default project was incorrectly always used).

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from as a code owner Jan 22, 2021
@plamut plamut requested review from tswast and removed request for Jan 22, 2021
@google-cla google-cla bot added the cla: yes label Jan 22, 2021
@plamut plamut changed the title fix: fix: use explicitly given project over the client's default project for load jobs Jan 22, 2021
tswast
tswast approved these changes Jan 22, 2021
Copy link
Contributor

@tswast tswast left a comment

Good catch, thanks!

Loading

@tswast tswast merged commit 530e1e8 into googleapis:master Jan 22, 2021
10 of 11 checks passed
Loading
@plamut plamut deleted the iss-473 branch Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants