Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mtls feature #492

Merged
merged 6 commits into from Feb 5, 2021
Merged

feat: add mtls feature #492

merged 6 commits into from Feb 5, 2021

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Jan 28, 2021

https://google.aip.dev/auth/4114
googlers see this doc for more details.

Part of the mtls feature is implemented in googleapis/python-cloud-core#75, and will be released as version 1.16.0.

This PR adds the mtls feature to bigquery client lib. Note that:
(1) if the python-cloud-core version is < 1.16.0, this PR does nothing, it is backward compatible and won't break any current users.
(2) if the user sets GOOGLE_API_USE_CLIENT_CERTIFICATE env var to "true" to trigger mtls, then the PR checks python-cloud-core version. It throws an exception asking the user to bump the version, if the version < 1.16.0. So probably it is a good idea to release python-cloud-core 1.16.0 before merging this PR.
(3) the unit tests work for both python-cloud-core versions, so unit test shouldn't break after the upgrading in the future.

google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
Loading
@arithmetic1728 arithmetic1728 changed the title [WIP] feat: add mtls feature feat: add mtls feature Jan 28, 2021
@arithmetic1728 arithmetic1728 marked this pull request as ready for review Feb 1, 2021
@arithmetic1728 arithmetic1728 requested a review from as a code owner Feb 1, 2021
@arithmetic1728 arithmetic1728 requested review from steffnay, tswast and busunkim96 and removed request for Feb 1, 2021
Copy link
Contributor

@tswast tswast left a comment

Looking good, thanks! Just a few nits.

Loading

google/cloud/bigquery/_http.py Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Show resolved Hide resolved
Loading
google/cloud/bigquery/client.py Show resolved Hide resolved
Loading
tests/unit/test__http.py Outdated Show resolved Hide resolved
Loading
arithmetic1728 and others added 4 commits Feb 4, 2021
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Tim Swast <swast@google.com>
@arithmetic1728
Copy link
Contributor Author

@arithmetic1728 arithmetic1728 commented Feb 4, 2021

Looking good, thanks! Just a few nits.

Committed all the suggested changes. Thank you!

Loading

tswast
tswast approved these changes Feb 5, 2021
@tswast tswast merged commit 1823cad into master Feb 5, 2021
10 of 11 checks passed
Loading
@tswast tswast deleted the mtls_rebase branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants