Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to close closed DB API cursors #498

Merged
merged 1 commit into from Jan 29, 2021

Conversation

@betodealmeida
Copy link
Contributor

@betodealmeida betodealmeida commented Jan 28, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #497 馃

@google-cla
Copy link

@google-cla google-cla bot commented Jan 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

Loading

@google-cla google-cla bot added the cla: no label Jan 28, 2021
@betodealmeida
Copy link
Contributor Author

@betodealmeida betodealmeida commented Jan 28, 2021

@googlebot I signed it!

Loading

@betodealmeida betodealmeida force-pushed the dont_close_closed_cursors branch from 5904b52 to f90188f Jan 28, 2021
@betodealmeida betodealmeida marked this pull request as ready for review Jan 28, 2021
@betodealmeida betodealmeida requested a review from as a code owner Jan 28, 2021
@betodealmeida betodealmeida requested review from steffnay and removed request for Jan 28, 2021
@plamut plamut changed the title fix: don't try to close closed cursors fix: don't try to close closed DB API cursors Jan 29, 2021
plamut
plamut approved these changes Jan 29, 2021
Copy link
Contributor

@plamut plamut left a comment

Looks good, thank you!

Loading

@plamut plamut merged commit bf44e7b into googleapis:master Jan 29, 2021
10 of 11 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants