Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify %%bigquery` magics and fix broken link #508

Merged
merged 1 commit into from Feb 16, 2021

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Feb 3, 2021

The link at https://googleapis.dev/python/bigquery/latest/usage/index.html
was broken. Also, I was having trouble remembering what I needed to do to
enable the %%bigquery extension, so I put that prerequisite right at the
top of the docs.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@tswast tswast requested a review from as a code owner Feb 3, 2021
@tswast tswast requested review from stephaniewang526 and removed request for Feb 3, 2021
@google-cla google-cla bot added the cla: yes label Feb 3, 2021
@tswast tswast requested review from steffnay and shollyman Feb 3, 2021
plamut
plamut approved these changes Feb 16, 2021
Copy link
Contributor

@plamut plamut left a comment

LGTM. The link in the docs now works and explaining how to load the extension can be useful, too.

Loading

@plamut plamut merged commit eedf93b into googleapis:master Feb 16, 2021
10 of 11 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants