Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add determinism level for javascript UDFs #522

Merged
merged 2 commits into from Feb 17, 2021
Merged

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Feb 15, 2021

Closes #503.

This PR adds support for the determinism level setting for user-defined routines.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from as a code owner Feb 15, 2021
@plamut plamut requested review from steffnay and removed request for Feb 15, 2021
@google-cla google-cla bot added the cla: yes label Feb 15, 2021
@plamut plamut requested a review from shollyman Feb 15, 2021
tests/system/test_client.py Outdated Show resolved Hide resolved
Loading
@plamut plamut requested a review from tswast Feb 17, 2021
tswast
tswast approved these changes Feb 17, 2021
Copy link
Contributor

@tswast tswast left a comment

Thanks!

Loading

@tswast tswast merged commit edd3328 into googleapis:master Feb 17, 2021
10 of 11 checks passed
Loading
@plamut plamut deleted the iss-503 branch Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants